Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8260926: Trace resource exhausted events unconditionally #2350

Closed
wants to merge 3 commits into from
Closed

JDK-8260926: Trace resource exhausted events unconditionally #2350

wants to merge 3 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Feb 2, 2021 •
edited by openjdk bot
Loading

Analyzing out-of-resource situations in cloud scenarios is no fun. With CloudFoundry, a JVMTI agent (jvmkill) is hooked up intercepting the jvmti "resource exhausted" event, then attempts to write up a heap report. That may fail, e.g. due to bugs in the agent [1], but also because that report runs java code and may suffer from the same resource exhaustion. Successful or not, it unceremoniously kills the VM when done, often leaving us with no information about the actual resource.

It would be very helpful if we had unconditional tracing here. We do have tracing, but it requires a non-product build and is triggered with TraceJVMTI. Also, it traces at trace level which is way to fine granular.

I'd like to introduce another, unconditional trace line here. Arguably, resource exhausted is fatal enough that it justifies unconditional tracing.

This is a bit of a coin toss. Tracing unconditionally would help in most scenarios, where it would be either difficult or even impossible to specify a trace command line switch. OTOH it may trip up scripts parsing the VM output, or some of our tests (which can be fixed).

Thoughts?

..Thomas

[1] cloudfoundry/jvmkill#18

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260926: Trace resource exhausted events unconditionally

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2350/head:pull/2350
$ git checkout pull/2350

@tstuefe tstuefe changed the title Add trace JDK-8260926: Trace resource exhausted events unconditionally Feb 2, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@tstuefe The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@tstuefe tstuefe marked this pull request as ready for review February 2, 2021 17:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2021 •
edited
Loading

Webrevs

dholmes-ora
dholmes-ora suggested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas,

Approval in principle, but changes suggested.

Thanks,
David

src/hotspot/share/prims/jvmtiExport.cpp Outdated Show resolved Hide resolved
@tstuefe
Copy link
Member Author

tstuefe commented Feb 3, 2021

Hi Thomas,

Approval in principle, but changes suggested.

Thanks,
David

Hi David, thanks for looking at this. I changed text and tag as requested.

..Thomas

coleenp
coleenp approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@openjdk
Copy link

openjdk bot commented Feb 4, 2021 •
edited
Loading

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260926: Trace resource exhausted events unconditionally

Reviewed-by: dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 4, 2021
@tstuefe
Copy link
Member Author

tstuefe commented Feb 4, 2021

Thanks, Coleen!

@dholmes-ora : are you fine with the latest version?

dholmes-ora
dholmes-ora approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have formatted the message differently as per my first comment. But ok.

@tstuefe
Copy link
Member Author

tstuefe commented Feb 5, 2021

I would have formatted the message differently as per my first comment. But ok.

Sorry, I misread part your original comment. I changed the message according to your suggestion.

Cheers, Thomas

@tstuefe
Copy link
Member Author

tstuefe commented Feb 5, 2021

/integrate

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2021
@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@tstuefe Since your change was applied there have been 63 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ee2f205.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8260926-trace-resource-exhausted branch February 5, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coleenp coleenp coleenp approved these changes

@dholmes-ora dholmes-ora dholmes-ora approved these changes

Assignees
No one assigned
Labels
hotspot [email protected] integrated Pull request has been integrated serviceability [email protected]
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tstuefe @coleenp @dholmes-ora